On 28.03.2025 02:18, Alexander Korotkov wrote:
Hi!
On Mon, Mar 24, 2025 at 2:46 PM Alena Rybakina
<a.rybakina@postgrespro.ru> wrote:
I agree with Andrey's changes and think we should fix this, because otherwise it might be inconvenient.
For example, without this changes we will have to have different test output files for the same query for different versions of Postres in extensions if the whole change is only related to the order of column output for a transformation that was not applied.
I agree with problem spotted by Andrei: it should be preferred to
preserve original order of clauses as much as possible. The approach
implemented in Andrei's patch seems fragile for me. Original order is
preserved if we didn't find any group. But once we find a single
group original order might be destroyed completely.
The attached patch changes the reordering algorithm of
group_similar_or_args() in the following way. We reorder each group
of similar clauses so that the first item of the group stays in place,
but all the other items are moved after it. So, if there are no
similar clauses, the order of clauses stays the same. When there are
some groups, only required reordering happens while the rest of the
clauses remain in their places.
I agree with your code in general, but to be honest, double qsort confused me a little.
I understood why it is needed - we need to sort the elements so that they stand next to each other if they can be assigned to the same group, and then sort the groups themselves according to the set identifier.
I may be missing something, but in the worst case we can get the complexity of qsort O(n^2), right? And I saw the letter where you mentioned this, but it is possible to use mergesort algorithm instead of qsort, which in the worst case gives n * O(n) complexity?
--
Regards,
Alena Rybakina
Postgres Professional
