Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing - Mailing list pgsql-committers

From Jeff Davis
Subject Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date
Msg-id e852442da35b4f31acc600ed98bbee0f12e65e0c.camel@j-davis.com
Whole thread Raw
In response to pgsql: pg_upgrade: Fix inconsistency in memory freeing  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
List pgsql-committers
On Fri, 2025-02-28 at 01:16 +0000, Michael Paquier wrote:
> pg_upgrade: Fix inconsistency in memory freeing

> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2a083ab807db6d9e2e0e3aa82ee8f6ff9fc44c8d
>

This seems to have broken the pg_upgrade test when olddump/oldinstall
are set to PG14 or earlier:

stderr:
#   Failed test 'check that locales in new cluster match original
cluster'
#   at
/home/jdavis/git/postgresql/src/bin/pg_upgrade/t/002_pg_upgrade.pl line
506.
#          got: '0|c|C|C|NULL'
#     expected: '0|c|C|C|'
# Looks like you failed 1 test of 16.

Looking at the commit, it seems you are escaping NULL as a literal.

Regards,
    Jeff Davis




pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: amcheck: Fix indentation in verify_gin.c
Next
From: Andres Freund
Date:
Subject: pgsql: aio: Implement support for reads in smgr/md/fd