pgsql: aio: Implement support for reads in smgr/md/fd - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: aio: Implement support for reads in smgr/md/fd
Date
Msg-id E1tyabt-001coq-07@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
aio: Implement support for reads in smgr/md/fd

This implements the following:

1) An smgr AIO target, for AIO on smgr files. This should be usable not just
   for md.c but also other SMGR implementation if we ever get them.
2) readv support in fd.c, which requires a small bit of infrastructure work in
   fd.c
3) smgr.c and md.c support for readv

There still is nothing performing AIO, but as of this commit it would be
possible.

As part of this change FileGetRawDesc() actually ensures that the file is
opened - previously it was basically not usable. It's used to reopen a file in
IO workers.

Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/uvrtrknj4kdytuboidbhwclo4gxhswwcpgadptsjvjqcluzmah%40brqs62irg4dt
Discussion: https://postgr.es/m/20210223100344.llw5an2aklengrmn@alap3.anarazel.de
Discussion: https://postgr.es/m/stj36ea6yyhoxtqkhpieia2z4krnam7qyetc57rfezgk4zgapf@gcnactj4z56m

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/50cb7505b3010736b9a7922e903931534785f3aa

Modified Files
--------------
src/backend/storage/aio/aio_callback.c |   3 +
src/backend/storage/aio/aio_target.c   |   2 +
src/backend/storage/file/fd.c          |  40 +++++++
src/backend/storage/smgr/md.c          | 196 +++++++++++++++++++++++++++++++++
src/backend/storage/smgr/smgr.c        | 161 +++++++++++++++++++++++++++
src/include/storage/aio.h              |   5 +-
src/include/storage/aio_types.h        |  10 +-
src/include/storage/fd.h               |   3 +
src/include/storage/md.h               |   7 ++
src/include/storage/smgr.h             |  14 +++
10 files changed, 437 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Next
From: Andres Freund
Date:
Subject: pgsql: aio, bufmgr: Comment fixes/improvements