Re: PL/Python warnings in CVS HEAD - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: PL/Python warnings in CVS HEAD
Date
Msg-id e51f66da0704040141g288969ehf97a57a6215a2f15@mail.gmail.com
Whole thread Raw
In response to Re: PL/Python warnings in CVS HEAD  (Bruce Momjian <bruce@momjian.us>)
Responses Re: PL/Python warnings in CVS HEAD  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On 4/3/07, Bruce Momjian <bruce@momjian.us> wrote:
> Great, patch applied and TODO item removed.

If you are already patching, please apply the following patch also.

It removes last remaining casts inside struct definitions.
Such usage is bad practice, as it hides problems from compiler.

Reason for the cast is popular practice in some circles
to define functions as foo(MyObj *) instead of foo(PyObject *)
thus avoiding a local variable inside functions and make
direct calling easier.  As pl/python does not use such style,
the casts were unnecessary from the start.

--
marko

Attachment

pgsql-hackers by date:

Previous
From: "Albe Laurenz"
Date:
Subject: Re: Bug in UTF8-Validation Code?
Next
From: Heikki Linnakangas
Date:
Subject: Vacuum in multi-statement