Re: PL/Python warnings in CVS HEAD - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: PL/Python warnings in CVS HEAD
Date
Msg-id 200704041728.l34HSCU15712@momjian.us
Whole thread Raw
In response to Re: PL/Python warnings in CVS HEAD  ("Marko Kreen" <markokr@gmail.com>)
List pgsql-hackers
Patch applied.  Thanks.

---------------------------------------------------------------------------


Marko Kreen wrote:
> On 4/3/07, Bruce Momjian <bruce@momjian.us> wrote:
> > Great, patch applied and TODO item removed.
> 
> If you are already patching, please apply the following patch also.
> 
> It removes last remaining casts inside struct definitions.
> Such usage is bad practice, as it hides problems from compiler.
> 
> Reason for the cast is popular practice in some circles
> to define functions as foo(MyObj *) instead of foo(PyObject *)
> thus avoiding a local variable inside functions and make
> direct calling easier.  As pl/python does not use such style,
> the casts were unnecessary from the start.
> 
> -- 
> marko

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Synchronized Scan benchmark results
Next
From: 4wheels
Date:
Subject: Finding Queries that have been done on a DB