Re: Newline after --progress report - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Newline after --progress report
Date
Msg-id e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi
Whole thread Raw
In response to Re: Newline after --progress report  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Newline after --progress report  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 14/08/2020 16:51, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Attached is a patch to fix this, as well as a similar issue in
>> pg_checksums. pg_basebackup and pgbench also print progres reports like
>> this, but they seem correct to me.
> 
> I wonder whether it'd be better to push the responsibility for this
> into progress_report(), by adding an additional parameter "bool last"
> or the like.  Then the callers would not need such an unseemly amount
> of knowledge about what progress_report() is doing.

Good point. Pushed a patch along those lines.

- Heikki



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE
Next
From: Heikki Linnakangas
Date:
Subject: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE