Re: Should heapam_estimate_rel_size consider fillfactor? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Should heapam_estimate_rel_size consider fillfactor?
Date
Msg-id e295128c-13e2-4d4f-a774-e493c9fe52fe@iki.fi
Whole thread Raw
In response to Should heapam_estimate_rel_size consider fillfactor?  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: Should heapam_estimate_rel_size consider fillfactor?
List pgsql-hackers
On 18/02/2025 14:01, Tomas Vondra wrote:
> On 2/4/25 17:54, Tomas Vondra wrote:
>> On 2/4/25 16:02, Tomas Vondra wrote:
>>> ...
>>>
>>> Thanks for the report. And yeah, clamping it to 1 seems like the right
>>> fix for this. I wonder if it's worth inventing some sort of test for
>>> this, shouldn't be too hard I guess.
>>>
>>> In any case, I'll take care of the fix/backpatch soon.
>>
>> Here's a proposed fix, including a simple test in the stats suite.
> 
> Here's a slightly improved fix, with a proper commit message and
> simplified test case. I plan to push this once the releases get out (I
> know it was stamped already, but ...).

Looks good, thanks!

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Support a wildcard in backtrace_functions
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: test_escape: invalid option -- 'c'