Re: Should heapam_estimate_rel_size consider fillfactor? - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Should heapam_estimate_rel_size consider fillfactor?
Date
Msg-id 66458313-f991-4c64-8440-d26aa6cbe231@vondra.me
Whole thread Raw
In response to Re: Should heapam_estimate_rel_size consider fillfactor?  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On 2/18/25 13:29, Heikki Linnakangas wrote:
> On 18/02/2025 14:01, Tomas Vondra wrote:
>> On 2/4/25 17:54, Tomas Vondra wrote:
>>> On 2/4/25 16:02, Tomas Vondra wrote:
>>>> ...
>>>>
>>>> Thanks for the report. And yeah, clamping it to 1 seems like the right
>>>> fix for this. I wonder if it's worth inventing some sort of test for
>>>> this, shouldn't be too hard I guess.
>>>>
>>>> In any case, I'll take care of the fix/backpatch soon.
>>>
>>> Here's a proposed fix, including a simple test in the stats suite.
>>
>> Here's a slightly improved fix, with a proper commit message and
>> simplified test case. I plan to push this once the releases get out (I
>> know it was stamped already, but ...).
> 
> Looks good, thanks!
> 

Pushed. Thanks!


-- 
Tomas Vondra




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: new commitfest transition guidance
Next
From: Ilia Evdokimov
Date:
Subject: Re: Sample rate added to pg_stat_statements