Re: libpq error message refactoring - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: libpq error message refactoring
Date
Msg-id e0d98802-143d-7294-a751-9c19faa15861@enterprisedb.com
Whole thread Raw
In response to libpq error message refactoring  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: libpq error message refactoring  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On 25.08.22 16:34, Peter Eisentraut wrote:
> libpq now contains a mix of error message strings that end with newlines 
> and don't end with newlines, due to some newer code paths with new ways 
> of passing errors around.  This has now gotten me confused a few too 
> many times both during development and translation.  So I looked into 
> whether we can unify this, similar to how we have done elsewhere (e.g., 
> pg_upgrade).  I came up with the attached patch.  It's not complete, but 
> it shows the idea and it looks like a nice simplification to me. 

I have completed this patch, taking into account the fixes discussed in 
this thread.

I have split the patch in two, for review: The first is just the new 
APIs, the second are the changes that apply the API everywhere.

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Move backup-related code to xlogbackup.c/.h
Next
From: Amit Langote
Date:
Subject: Re: generic plans and "initial" pruning