libpq error message refactoring - Mailing list pgsql-hackers

From Peter Eisentraut
Subject libpq error message refactoring
Date
Msg-id 7c0232ef-7b44-68db-599d-b327d0640a77@enterprisedb.com
Whole thread Raw
Responses Re: libpq error message refactoring
Re: libpq error message refactoring
List pgsql-hackers
libpq now contains a mix of error message strings that end with newlines 
and don't end with newlines, due to some newer code paths with new ways 
of passing errors around.  This has now gotten me confused a few too 
many times both during development and translation.  So I looked into 
whether we can unify this, similar to how we have done elsewhere (e.g., 
pg_upgrade).  I came up with the attached patch.  It's not complete, but 
it shows the idea and it looks like a nice simplification to me. 
Thoughts on this approach?
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Letter case of "admin option"
Next
From: Robert Haas
Date:
Subject: Re: pg_basebackup: add test about zstd compress option