On 2017/06/12 22:46, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
>> How about something like the attached? The patch makes
>> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on
>> WithCheckOption.qual that is being initialized for each partition.
>
> Well, the question then is whether that behaves correctly. Where it would
> matter is if the WCO qual contains a SubPlan, because you'd be adding
> multiple instances of the subplan to the PlanState's list. I think it's
> probably all right, but it might be wise to add a test case where there
> is such a subplan.
>
> Spacing and comment wording seem a bit random in this, too.
Was about to send the updated patch, but noticed that you already
committed it after adding the test. Thanks a lot.
Regards,
Amit
