Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.
Date
Msg-id 7444.1497275164@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-committers
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> How about something like the attached? The patch makes
> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on
> WithCheckOption.qual that is being initialized for each partition.

Well, the question then is whether that behaves correctly.  Where it would
matter is if the WCO qual contains a SubPlan, because you'd be adding
multiple instances of the subplan to the PlanState's list.  I think it's
probably all right, but it might be wise to add a test case where there
is such a subplan.

Spacing and comment wording seem a bit random in this, too.

            regards, tom lane


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Stop table sync workers when subscription relation entry isremo
Next
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Trim trailing whitespace