Re: tests fail on windows with default git settings - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: tests fail on windows with default git settings
Date
Msg-id e006b6a2-2f8e-4463-a58e-09cd51280432@dunslane.net
Whole thread Raw
In response to Re: tests fail on windows with default git settings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: tests fail on windows with default git settings
List pgsql-hackers
On 2024-07-07 Su 1:26 AM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Do we want to support checking out with core.autocrlf?
> -1.  It would be a constant source of breakage, and you could never
> expect that (for example) making a tarball from such a checkout
> would match anyone else's results.


Yeah, totally agree.


>> If we do not want to support that, ISTM we ought to raise an error somewhere?
> +1, if we can figure out how.
>
>             



ISTM the right fix is probably to use PG_BINARY_R mode instead of "r" 
when opening the files, at least in the case if the test_json_parser tests.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: Pluggable cumulative statistics
Next
From: David Rowley
Date:
Subject: Optimize WindowAgg's use of tuplestores