Re: Nicer error when connecting to standby with hot_standby=off - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Nicer error when connecting to standby with hot_standby=off
Date
Msg-id dfd1c88a-f594-5d96-32cf-b6382b7ba8f5@oss.nttdata.com
Whole thread Raw
In response to Re: Nicer error when connecting to standby with hot_standby=off  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Nicer error when connecting to standby with hot_standby=off
List pgsql-hackers

On 2021/03/24 16:59, Alvaro Herrera wrote:
> On 2021-Mar-24, Fujii Masao wrote:
> 
>> On 2021/03/24 5:59, Tom Lane wrote:
>>> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>>>> FATAL:  the database system is starting up
>>>> DETAIL:  WAL is being applied to recover from a system crash.
>>>> or
>>>> DETAIL:  The system is applying WAL to recover from a system crash.
>>>> or
>>>> DETAIL:  The startup process is applying WAL to recover from a system crash.
>>>
>>> I don't think the postmaster has enough context to know if that's
>>> actually true.  It just launches the startup process and waits for
>>> results.  If somebody saw this during a normal (non-crash) startup,
>>> they'd be justifiably alarmed.
>>
>> Yes, so logging "the database system is starting up" seems enough to me.
> 
> No objection.

Thanks! So I changed the message reported at PM_STARTUP to that one,
based on v8 patch that James posted upthread. I also ran pgindent for
the patch. Attached is the updated version of the patch.

Barring any objection, I will commit this.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Custom compression methods
Next
From: Christoph Berg
Date:
Subject: Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres