Hi,
I agree with these changes in general - I have a couple minor comment:
1) 0001
- the SGML docs are missing a couple tags
- The blocks in copyfrom.cc/copyto.c should be reworked - I don't think
we do this in our codebase. Move the variable declarations to the
beginning, get rid of the out block. Or something like that.
- I fir the "io_target" name misleading, because in some cases it's
actually the *source*.
2) 0002
- I believe "each backend ... reports its" (not theirs), right?
- This seems more like a generic docs improvement, not quite specific to
the COPY progress patch. It's a bit buried, maybe it should be posted
separately. OTOH it's pretty small.
3) 0003
- Some whitespace noise, triggering "git am" warnings.
- Might be good to briefly explain what the regression test does with
the triggers, etc.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
