Re: Sparse bit set data structure - Mailing list pgsql-hackers

From Adrien NAYRAT
Subject Re: Sparse bit set data structure
Date
Msg-id dd07fed3-99aa-a2e1-19e2-c14e1e898049@anayrat.info
Whole thread Raw
In response to Re: Sparse bit set data structure  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Sparse bit set data structure
List pgsql-hackers
Hello,

According to the draw and simple8b_mode struct comment, it seems there 
is a typo:

> *      20-bit integer       20-bit integer       20-bit integer
>  * 1101 00000000000000010010 01111010000100100000 00000000000000010100
>  * ^
>  * selector
>  *
>  * The selector 1101 is 13 in decimal.  From the modes table below, we see
>  * that it means that the codeword encodes three 12-bit integers.  In decimal,
>  * those integers are 18, 500000 and 20.  Because we encode deltas rather than
>  * absolute values, the actual values that they represent are 18, 500018 and
>  * 500038.
[...]
>     {20, 3},                    /* mode 13: three 20-bit integers */


The comment should be "the codeword encodes three *20-bit* integers" ?

Patch attached.

Regards,

Attachment

pgsql-hackers by date:

Previous
From: "Fred .Flintstone"
Date:
Subject: Re: PostgreSQL pollutes the file system
Next
From: Fabien COELHO
Date:
Subject: Re: Progress reporting for pg_verify_checksums