Re: It is not documented that pg_promote can exit standby mode - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: It is not documented that pg_promote can exit standby mode
Date
Msg-id dc6041f6-db27-d2a8-9ba9-379d7ad90522@oss.nttdata.com
Whole thread Raw
In response to Re: It is not documented that pg_promote can exit standby mode  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: It is not documented that pg_promote can exit standby mode  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers

On 2020/04/18 2:46, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> Thanks for the report and the patch! It looks good to me.
>> Barring any objection, I will commit this patch.
> 
> It might be worth writing "<function>pg_promote()</function> is called"
> (adding parentheses) to make it clearer that a function is being
> referred to.  No objection otherwise.

Yes. Also Masahiro-san reported me, off-list, that there are other places
where pg_promote is mentioned without parentheses. I think it's better to
add parentheses there. Attached is the updated version of the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Allow pg_read_all_stats to read pg_stat_progress_*
Next
From: Amit Kapila
Date:
Subject: Re: design for parallel backup