Re: It is not documented that pg_promote can exit standby mode - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: It is not documented that pg_promote can exit standby mode
Date
Msg-id 1116f41c-ae6e-1217-0bb6-87c176ece969@oss.nttdata.com
Whole thread Raw
In response to Re: It is not documented that pg_promote can exit standby mode  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers

On 2020/04/20 20:38, Fujii Masao wrote:
> 
> 
> On 2020/04/18 2:46, Tom Lane wrote:
>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>> Thanks for the report and the patch! It looks good to me.
>>> Barring any objection, I will commit this patch.
>>
>> It might be worth writing "<function>pg_promote()</function> is called"
>> (adding parentheses) to make it clearer that a function is being
>> referred to.  No objection otherwise.
> 
> Yes. Also Masahiro-san reported me, off-list, that there are other places
> where pg_promote is mentioned without parentheses. I think it's better to
> add parentheses there. Attached is the updated version of the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix for pg_statio_all_tables
Next
From: Amit Langote
Date:
Subject: Re: Parallel Append can break run-time partition pruning