Re: [PATCH] Add native windows on arm64 support - Mailing list pgsql-hackers

From Niyas Sait
Subject Re: [PATCH] Add native windows on arm64 support
Date
Msg-id dbee741f-b9b7-a0d5-1b1b-f9b532bb6f56@linaro.org
Whole thread Raw
In response to Re: [PATCH] Add native windows on arm64 support  (Niyas Sait <niyas.sait@linaro.org>)
Responses Re: [PATCH] Add native windows on arm64 support
Re: [PATCH] Add native windows on arm64 support
List pgsql-hackers
On 19/01/2023 10:09, Niyas Sait wrote:
> 
> 
> On 17/01/2023 22:51, Andres Freund wrote:

>>>   int main(void)
>>> @@ -1960,18 +1966,19 @@ int main(void)
>>>   }
>>>   '''
>>> -  if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and 
>>> __crc32cd without -march=armv8-a+crc',
>>> -      args: test_c_args)
>>> -    # Use ARM CRC Extension unconditionally
>>> -    cdata.set('USE_ARMV8_CRC32C', 1)
>>> -    have_optimized_crc = true
>>> -  elif cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and 
>>> __crc32cd with -march=armv8-a+crc',
>>> -      args: test_c_args + ['-march=armv8-a+crc'])
>>> -    # Use ARM CRC Extension, with runtime check
>>> -    cflags_crc += '-march=armv8-a+crc'
>>> -    cdata.set('USE_ARMV8_CRC32C', false)
>>> -    cdata.set('USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK', 1)
>>> -    have_optimized_crc = true
>>> +    if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and 
>>> __crc32cd without -march=armv8-a+crc',
>>> +        args: test_c_args)
>>
>> Seems like it'd be easier to read if you don't re-indent this, but 
>> just have
>> the cc.get_id() == 'msvc' part of this if/else-if.
>>
> 

I've attached a new version (v8) to fix the above indentation issue.

Could someone please help with the review ?

-- 
Niyas
Attachment

pgsql-hackers by date:

Previous
From: Alexander Pyhalov
Date:
Subject: Re: buffer refcount leak in foreign batch insert code
Next
From: Peter Eisentraut
Date:
Subject: Re: min/max aggregation for jsonb