Re: Collation versions on Windows (help wanted, apply within) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Collation versions on Windows (help wanted, apply within)
Date
Msg-id d86fd312-ae0c-1380-f860-46ae711116d6@2ndquadrant.com
Whole thread Raw
In response to Re: Collation versions on Windows (help wanted, apply within)  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Collation versions on Windows (help wanted, apply within)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On 2019-11-26 21:39, Thomas Munro wrote:
> On Fri, Nov 8, 2019 at 12:44 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>> The reason for returning an empty string for "C" and "POSIX" is the
>> following comment for get_collation_actual_version():
>>
>>   * A particular provider must always either return a non-NULL string or return
>>   * NULL (if it doesn't support versions).  It must not return NULL for some
>>   * collcollate and not NULL for others.
>>
>> I'm not sure why, or if that really makes sense.
> 
> Peter E, do you have any thoughts on this question?

Doesn't make sense to me either.

We need to handle the various combinations of null and non-null stored 
and actual versions, which we do, but that only applies within a given 
collcollate.  I don't think we need the property that that comment calls 
for.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Regression tests vs existing users in an installation
Next
From: Masahiko Sawada
Date:
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace onthe fly