On 2018/03/22 20:48, Pavan Deolasee wrote:
> Thanks. It's looking much better now.
Thanks.
> I think we can possibly move all ON
> CONFLICT related members to a separate structure and just copy the pointer
> to the structure if (map == NULL). That might make the code a bit more tidy.
OK, I tried that in the attached updated patch.
> Is there anything that needs to be done for transition tables? I checked
> and didn't see anything, but please check.
There doesn't seem to be anything that this patch has to do for transition
tables. If you look at the tests I added in triggers.sql which exercise
INSERT ON CONFLICT's interaction with transition tables, you can see that
we get the same output for a partitioned table as we get for a normal table.
Thanks,
Amit
