Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?
Date
Msg-id d42969ae-fac8-f116-2434-e7bce37f7ce1@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Responses Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
On 4/20/17 14:29, Petr Jelinek wrote:
> +        /* Find unused worker slot. */
> +        if (!w->in_use)
>          {
> -            worker = &LogicalRepCtx->workers[slot];
> -            break;
> +            worker = w;
> +            slot = i;
> +        }

Doesn't this still need a break?  Otherwise it always picks the last slot.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] Interval for launching the table sync worker
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?