Re: WAL and commit_delay - Mailing list pgsql-hackers

From Jerome Vouillon
Subject Re: WAL and commit_delay
Date
Msg-id d3z1ysw0vwz.fsf@saul.cis.upenn.edu
Whole thread Raw
In response to Re: WAL and commit_delay  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: WAL and commit_delay  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> The implication is that the only thing you can lose after fdatasync is
> the highly-inessential file mod time.  However, I have been told that
> on some implementations, fdatasync only flushes data blocks, and never
> writes the inode or indirect blocks.  That would mean that if you had
> allocated new disk space to the file, fdatasync would not guarantee
> that that allocation was reflected on disk.  This is the reason for
> preallocating the WAL log file (and doing a full fsync *at that time*).
> Then you know the inode block pointers and indirect blocks are down
> on disk, and so fdatasync is sufficient even if you have the cheesy
> version of fdatasync.

Actually, there is also a performance reason. Indeed, fdatasync would
not perform any better than fsync if the log file was not
preallocated: the file length would change each time a record is
appended, and therefore the inode would have to be updated.

-- Jerome


pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: Re: WAL and commit_delay
Next
From: Tom Lane
Date:
Subject: Re: Re: WAL and commit_delay