Re: libpq_pipeline in tmp_install - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: libpq_pipeline in tmp_install
Date
Msg-id d35be8c9-3c8e-25a6-298b-fd9ddcb1a02b@enterprisedb.com
Whole thread Raw
In response to libpq_pipeline in tmp_install  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: libpq_pipeline in tmp_install
List pgsql-hackers
On 10.05.21 20:26, Peter Eisentraut wrote:
> The test program libpq_pipeline produced by the test suite in 
> src/test/modules/libpq_pipeline/ is installed into tmp_install as part 
> of make check.  This isn't a real problem by itself, but I think it 
> creates a bit of an asymmetric situation that might be worth cleaning up.
> 
> Before, the contents of tmp_install exactly matched an actual 
> installation.  There were no extra test programs installed.
> 
> Also, the test suite code doesn't actually use that installed version, 
> so it's not of any use, and it creates confusion about which copy is in 
> use.
> 
> The reason this is there is that the test suite uses PGXS to build the 
> test program, and so things get installed automatically.  I suggest that 
> we should either write out the build system by hand to avoid this, or 
> maybe extend PGXS to support building programs but not installing them. 

Here is a patch that implements the second solution, which turned out to 
be very easy.

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Next
From: Fujii Masao
Date:
Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.