Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Date
Msg-id 63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com
Whole thread Raw
In response to Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
List pgsql-hackers
Tree view 

On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
> +1 for adding some tests for pg_wal_replay_pause() but the test seems
> like checking only that pg_get_wal_replay_pause_state() returns the
> expected state value.  Don't we need to check that the recovery is
> actually paused and that the promotion happens at expected LSN?

Sounds good. Attached is the updated version of the patch.
I added such checks into the test.

BTW, while reading some recovery regression tests, I found that
013_crash_restart.pl has "use Time::HiRes qw(usleep)" but it seems
not necessary. We can safely remove that? Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: libpq_pipeline in tmp_install
Next
From: "osumi.takamichi@fujitsu.com"
Date:
Subject: Deadlock concern caused by TRUNCATE on user_catalog_table in synchronous mode