Re: save redundant code for pseudotype I/O functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: save redundant code for pseudotype I/O functions
Date
Msg-id d0014805-67b8-8b81-02e4-86e0bd2b0888@2ndquadrant.com
Whole thread Raw
In response to Re: save redundant code for pseudotype I/O functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 10/28/16 9:25 AM, Tom Lane wrote:
> Would it be better to use CppAsString and CppConcat instead of directly
> using # and ##, for consistency with what we do elsewhere?

I modeled this after several similar places in gin and tsearch code,
which use ##:

contrib/btree_gin/btree_gin.c
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/tsvector_op.c

Do people prefer the macros over this?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Mithun Cy
Date:
Subject: Re: Patch: Implement failover on libpq connect level.
Next
From: Robert Haas
Date:
Subject: Re: Patch: Implement failover on libpq connect level.