Re: save redundant code for pseudotype I/O functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: save redundant code for pseudotype I/O functions
Date
Msg-id 12183.1477661103@sss.pgh.pa.us
Whole thread Raw
In response to Re: save redundant code for pseudotype I/O functions  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: save redundant code for pseudotype I/O functions  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 10/27/16 11:49 PM, Peter Eisentraut wrote:
>> Here is a patch to refactor some of the I/O functions in pseudotypes.c
>> to save redundant code and reduce the number of distinct translatable
>> strings.

Would it be better to use CppAsString and CppConcat instead of directly
using # and ##, for consistency with what we do elsewhere?

Otherwise, +1.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: emergency outage requiring database restart
Next
From: Tom Lane
Date:
Subject: Re: Radix tree for character conversion