Re: psql - factor out echo code - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: psql - factor out echo code
Date
Msg-id cf982bbd-b6d4-8855-cef-78e1adb77374@mines-paristech.fr
Whole thread Raw
In response to Re: psql - factor out echo code  (Michael Paquier <michael@paquier.xyz>)
Responses Re: psql - factor out echo code
List pgsql-hackers
> Hmm.  The refactoring is worth it as much as the differentiation
> between QUERY and INTERNAL QUERY as the same pattern is repeated 5
> times.
>
> Now some of the output generated by test_extdepend gets a bit
> confusing:
> +-- QUERY:
> +
> +
> +-- QUERY:
>
> That's not entirely this patch's fault.  Still that's not really
> intuitive to see the output of a query that's just a blank spot..

Hmmm.

What about adding an explicit \echo before these empty outputs to mitigate 
the possible induced confusion?

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Jelte Fennema
Date:
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Next
From: Fabien COELHO
Date:
Subject: Re: psql - factor out echo code