Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c) - Mailing list pgsql-hackers

From Ilia Evdokimov
Subject Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
Date
Msg-id cb8484eb-4d73-46d8-9a5f-a72cf896dd0f@tantorlabs.com
Whole thread Raw
In response to Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
List pgsql-hackers
Tree view 
But what should we do if cheapest == NULL further? Should we return NULL 
of get_cheapest_parameterized_child_path() function?

If it is, we should write it like this:

if (cheapset == NULL || bms(PATH_REQ_OUTER(cheapset), required_outer))
     return cheapest;

I'll look into this issue further.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
Next
From: Daniel Gustafsson
Date:
Subject: Re: Remove unnecessary static specifier