Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
Date
Msg-id CAEudQApBsYrMOb8nNNT8a=j8BYkFKXCK11ycbN0KVFe7Jjy05Q@mail.gmail.com
Whole thread Raw
In response to Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)  (Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>)
Responses Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
List pgsql-hackers
Tree view
Hi.

Em qua., 5 de fev. de 2025 às 13:51, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> escreveu:

On 05.01.2025 02:29, Ranier Vilela wrote:
> Hi.
>
> Per Coverity.
>
> All call sites of function *get_cheapest_path_for_pathkeys* checks
> for NULL returns.
>
> So, it is highly likely that the function will return NULL.
>
> IMO, the Assert in this particular call, is not fully effective.
>
> Fix removing the Assert and always check if the return is NULL.
>
> best regards,
> Ranier Vilela


Hi!

Thanks for noticing this. If this happens in the planner, it poses a
serious risk of a segmentation fault that could crash the instance if a
NULL pointer is dereferenced. Since checking for NULL is very cheap, I
support this patch.
Thanks for taking a look.

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Ilia Evdokimov
Date:
Subject: Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)
Next
From: Daniel Gustafsson
Date:
Subject: Re: Avoid possible deference NULL pointer (src/backend/optimizer/path/allpaths.c)