Re: Index AM API cleanup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Index AM API cleanup
Date
Msg-id c96e58c8-db51-4ce7-b795-6f321e44d147@eisentraut.org
Whole thread Raw
In response to Re: Index AM API cleanup  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: Index AM API cleanup
List pgsql-hackers
On 03.09.24 19:26, Mark Dilger wrote:
>> On Sep 3, 2024, at 9:52 AM, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Here is a cleaned-up version of the v17-0004 patch.  I have applied the renaming discussed above.  I have also made
awrapper function btgettreeheight() that calls _bt_getrootheight().  That way, if we ever want to change the API, we
don'thave to change _bt_getrootheight(), or disentangle it then.  I've also added documentation and put in a source
codecomment that the API could be expanded for additional uses.
 
> 
> Ok.
> 
>>   Also, I have removed the addition to the IndexOptInfo struct; that didn't seem necessary.
> 
> Good catch.  I agree with the change.

I have committed this patch.  (It needed another small change to silence 
a compiler warning about an uninitialized variable.)




pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: Re: First draft of PG 17 release notes
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Conflict detection for update_deleted in logical replication