Re: killing perl2host - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: killing perl2host
Date
Msg-id c65a8781-77ac-ea95-d185-6db291e1baeb@dunslane.net
Whole thread Raw
In response to killing perl2host  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: killing perl2host  (Andrew Dunstan <andrew@dunslane.net>)
Re: killing perl2host  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2/16/22 15:46, Andrew Dunstan wrote:
> Largely following a recipe from Andres, I have migrated buildfarm
> animals fairywren and jacana to a setup that shouldn't need (and in fact
> won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT these
> two are the only buildfarm animals that run TAP tests under msys.

[...]


> I suggest that we apply this patch:
>
>
[...]
>
> and if nothing breaks in a few days I will set about a more thorough
> removal of perl2host() and adjusting everywhere it's called, and we can
> forget that the whole sorry mess ever happened :-) I know a number of
> people who will be overjoyed.
>
>


OK, nothing broke, so here are two more invasive patches. The first
removes perl2host completely and adjusts  all the places that use it.
The second removes almost all the remaining msys special processing in
TAP tests.


I have tested these and they appear to work fine.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: Re: use rotate macro in more places
Next
From: Tom Lane
Date:
Subject: Re: use rotate macro in more places