Re: use rotate macro in more places - Mailing list pgsql-hackers

From Tom Lane
Subject Re: use rotate macro in more places
Date
Msg-id 74469.1645294929@sss.pgh.pa.us
Whole thread Raw
In response to Re: use rotate macro in more places  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: use rotate macro in more places  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
Yugo NAGATA <nagata@sraoss.co.jp> writes:
> For avoiding undefined behaviours,  maybe it is better to use unsigned
> int and bit mask as a following code in Linux does[1][2], though it
> would be unnecessary if they are used properly as in the current
> PostgreSQL code.

I don't think that's an improvement.  It would mask buggy calls.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: killing perl2host
Next
From: Joseph Koshakow
Date:
Subject: Re: Fix formatting of Interval output