Re: use rotate macro in more places - Mailing list pgsql-hackers

From John Naylor
Subject Re: use rotate macro in more places
Date
Msg-id CAFBsxsGOOPwU2hWYSJYKHwYKkwmu9m60cOpzSYA_=8LQykH6MQ@mail.gmail.com
Whole thread Raw
In response to Re: use rotate macro in more places  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Feb 20, 2022 at 1:03 AM Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> I think we can use this macro also in hash_multirange, hash_range,
> and JsonbHashScalarValue as in the attached patch. How about replacing
> them with the macro, too.

Good find. I also found one more in hashfn.c.

On Sat, Feb 19, 2022 at 11:28 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Some comments now look a bit too obvious to keep around, but maybe
> > they should be replaced with a "why", instead of a "what":
>
> Yeah.  Maybe like "combine successive hashkeys by rotating"?

Done that way.

Pushed, thank you both for looking!
-- 
John Naylor
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: do only critical work during single-user vacuum?
Next
From: Andrey Borodin
Date:
Subject: Re: MultiXact\SLRU buffers configuration