On 2018/10/25 12:43, David Rowley wrote:
> While doing a bit of work on a partitioning patch I noticed that it's
> not really that obvious that there's meant to be exactly 1 item in the
> partexprs List for each zero-valued partattrs element. Some incorrect
> code using these fields was the cause of CVE-2018-1052, so I think
> it's worthwhile to mention how they should be used in the comments.
>
> Patch attached.
Good idea.
+ * key, one for each zero-valued partattrs */
How about: for each zero-valued member of partattrs?
Regards,
Amit
