Re: OpenSSL 1.1 breaks configure and more - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: OpenSSL 1.1 breaks configure and more
Date
Msg-id c44c23af-c003-523b-a987-6c79349dee4c@proxel.se
Whole thread Raw
In response to Re: OpenSSL 1.1 breaks configure and more  (Christoph Berg <myon@debian.org>)
Responses Re: OpenSSL 1.1 breaks configure and more  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 06/27/2016 08:12 PM, Christoph Berg wrote:
> Re: Andreas Karlsson 2016-06-27 <8a0a5959-0b83-3dc8-d9e7-66ce8c1c5bc7@proxel.se>
>>> The errors you report make it sound like they broke API compatibility
>>> wholesale.  Was that really their intent?  If so, where are the changes
>>> documented?
>>
>> I do not see that they have documented the removal of the SSL_library_init
>> symbol anywhere. They changed the function into a macro in the following
>> commit. I guess we have to check for some other symbol, like SSL_new.
>
> I'm not an autoconf expert, but as said in the original mail, I could
> get the SSL_library_init check to work, even if that's a macro now:

Yes, we could do that, but I do not think we should check for the 
existence of a backwards compatibility macro. Actually I think we may 
want to skip much of the OpenSSL initialization code when compiling 
against OpenSSL 1.1 since they have now added automatic initialization 
of the library. Instead I think we should check for something we 
actually will use like SSL_CTX_new().

Andreas



pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: OpenSSL 1.1 breaks configure and more
Next
From: Christoph Berg
Date:
Subject: Re: Broken handling of lwlocknames.h