Re: SLRUs in the main buffer pool, redux - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: SLRUs in the main buffer pool, redux
Date
Msg-id c119ffc2-110e-f614-09ab-73d046238982@iki.fi
Whole thread Raw
In response to Re: SLRUs in the main buffer pool, redux  (Shawn Debnath <clocksweep@gmail.com>)
Responses Re: SLRUs in the main buffer pool, redux
List pgsql-hackers
On 20/01/2023 19:00, Shawn Debnath wrote:
> On Mon, Jul 25, 2022 at 11:54:36AM +0300, Heikki Linnakangas wrote:
> 
>> Oh I just saw that you had a comment about that in the patch and had hacked
>> around it. Anyway, calling ResourceOwnerEnlargeBuffers() might be a
>> solution. Or switch to a separate "CriticalResourceOwner" that's guaranteed
>> to have enough pre-allocated space, before entering the critical section.
> 
> Wanted to bump up this thread. Rishu in my team posted a patch in the other
> SLRU thread [1] with the latest updates and fixes and looks like performance
> numbers do not show any regression. This change is currently in the
> January commitfest [2] as well. Any feedback would be appreciated!

Here's a rebased set of patches.

The second patch is failing the pg_upgrade tests. Before I dig into 
that, I'd love to get some feedback on this general approach.

- Heikki

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Allow logical replication to copy tables in binary format
Next
From: Daniel Gustafsson
Date:
Subject: Re: Stale references to guc.c in comments/tests