Re: Stale references to guc.c in comments/tests - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Stale references to guc.c in comments/tests
Date
Msg-id 41096367-19A5-4DF9-8702-60C2C0BE4587@yesql.se
Whole thread Raw
In response to Re: Stale references to guc.c in comments/tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Stale references to guc.c in comments/tests
List pgsql-hackers
> On 24 Feb 2023, at 16:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I happened to notice that there were a few references to guc.c regarding
>> variables, which with the recent refactoring in 0a20ff54f have become stale.
>> Attached is a trivial patch to instead point to guc_tables.c.
>
> Hmm, I think you may have done an overenthusiastic replacement here.

Fair enough, I only changed those places I felt referenced variables, or their
definition, in guc_tables.c but I agree that there is a lot of greyzone in the
interpretation.

> Perhaps you could use "the GUC mechanisms" in these places, but it's a bit
> longer than "guc.c".  Leaving such references alone seems OK too.

I've opted for mostly leaving them in the attached v2.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: SLRUs in the main buffer pool, redux
Next
From: Andrew Dunstan
Date:
Subject: Re: meson vs make: missing/inconsistent ENV