Re: [PATCH] Remove workarounds to format [u]int64's - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Remove workarounds to format [u]int64's
Date
Msg-id c0f67e77-6ba2-c05a-d75a-50ea5a807107@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Remove workarounds to format [u]int64's  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Remove workarounds to format [u]int64's
List pgsql-hackers
On 21.03.22 15:37, Aleksander Alekseev wrote:
>> It would not simplify things for them at all, just mess it up.
>> The master copies of the .po files are kept in a different repo.
>> Also, I believe that extraction of new message strings is automated
>> already.
> 
> Got it, thanks. Here is the corrected patch. It includes all the
> changes by me and Japin, and doesn't touch PO files.

I think in some cases we can make this even simpler (and cast-free) by 
changing the underlying variable to be long long instead of int64. 
Especially in cases where the whole point of the variable is to be some 
counter that ends up being printed, there isn't a need to use int64 in 
the first place.  See attached patch for examples.
Attachment

pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: MDAM techniques and Index Skip Scan patch
Next
From: Peter Geoghegan
Date:
Subject: Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations