Re: parallel.c is not marked as test covered - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: parallel.c is not marked as test covered
Date
Msg-id bfd204ab-ab1a-792a-b345-0274a09a4b5f@2ndquadrant.com
Whole thread Raw
In response to Re: parallel.c is not marked as test covered  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: parallel.c is not marked as test covered  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 6/14/16 12:37 PM, Robert Haas wrote:
> ERROR: can't generate random numbers because you haven't specified a seed
>
> ...to which the user will reply, "oh yes I did; in fact I ran SELECT
> magic_setseed(42) just before I ran the offending query!".  They'll
> then contact an expert (hopefully) who will very possibly spend a lot
> of time troubleshooting the wrong thing.  If the message says:
>
> ERROR: can't generate random numbers because you haven't specified a seed
> CONTEXT: parallel worker, PID 62413
>
> ...then the expert has a very good chance of guessing what has gone
> wrong right away.

My updated opinion is to keep the context but remove the PID.  I can see 
that as this feature is being introduced, we will want to know that 
something is happening inside a parallel worker.  Maybe in the future 
we'll have it all figured out and won't need the context anymore.  But 
the PID is not useful by the time you see the message.  The server log 
should contain a trace of the PIDs if you need to do deep digging.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: increase message string buffer size of watch command of psql
Next
From: Robert Haas
Date:
Subject: Re: parallel.c is not marked as test covered