Re: increase message string buffer size of watch command of psql - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: increase message string buffer size of watch command of psql
Date
Msg-id 20160615203803.GA25616@alvherre.pgsql
Whole thread Raw
In response to Re: increase message string buffer size of watch command of psql  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: increase message string buffer size of watch command of psql  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> I wrote:

> > Well, we did part of that, but it's still using asctime().  Should we
> > change that to strftime(..."%c"...) to be less English-centric?
> > (The result seems to be the same in C locale.  pg_controldata has done
> > it that way for a long time, with few complaints.)  If we want to do so,
> > now would be the time, since 9.6 already whacked around the format
> > of \watch output.
> 
> I take it from the vast silence that nobody particularly cares one way
> or the other.  On reflection I think that this would be a good change
> to make, so I'll go do so unless I hear complaints soon.

+1 to strftime("%c").  If we wanted to provide additional flexibility we
could have a \pset option to change the strftime format string to
something other than %c, but I don't think there's enough demand to
justify it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Peter Eisentraut
Date:
Subject: Re: parallel.c is not marked as test covered