ecpg_config.h symbol missing with meson - Mailing list pgsql-hackers

From Peter Eisentraut
Subject ecpg_config.h symbol missing with meson
Date
Msg-id bf35d032-02fc-4173-9f4f-840999cc3ef3@eisentraut.org
Whole thread Raw
Responses Re: ecpg_config.h symbol missing with meson
List pgsql-hackers
I checked the generated ecpg_config.h with make and meson, and the meson 
one is missing

#define HAVE_LONG_LONG_INT 1

This is obviously quite uninteresting, since that is required by C99. 
But it would be more satisfactory if we didn't have discrepancies like 
that.  Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for 
compatibility.

Fixing this on the meson side would be like

diff --git a/src/interfaces/ecpg/include/meson.build 
b/src/interfaces/ecpg/include/meson.build
index 31610fef589..b85486acbea 100644
--- a/src/interfaces/ecpg/include/meson.build
+++ b/src/interfaces/ecpg/include/meson.build
@@ -12,6 +12,7 @@ ecpg_conf_keys = [
  ecpg_conf_data = configuration_data()

  ecpg_conf_data.set('ENABLE_THREAD_SAFETY', 1)
+ecpg_conf_data.set('HAVE_LONG_LONG_INT', 1)

  foreach key : ecpg_conf_keys
    if cdata.has(key)

Alternatively, we could remove the symbol from the make side.



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Parallel CREATE INDEX for BRIN indexes
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: Speed up clean meson builds by ~25%