Re: ecpg_config.h symbol missing with meson - Mailing list pgsql-hackers

From Tom Lane
Subject Re: ecpg_config.h symbol missing with meson
Date
Msg-id 1580077.1713370500@sss.pgh.pa.us
Whole thread Raw
In response to ecpg_config.h symbol missing with meson  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: ecpg_config.h symbol missing with meson
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> I checked the generated ecpg_config.h with make and meson, and the meson 
> one is missing

> #define HAVE_LONG_LONG_INT 1

> This is obviously quite uninteresting, since that is required by C99. 
> But it would be more satisfactory if we didn't have discrepancies like 
> that.  Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for 
> compatibility.
> ...
> Alternatively, we could remove the symbol from the make side.

Think I'd vote for removing it, since we use it nowhere.
The ENABLE_THREAD_SAFETY precedent feels a little bit different,
since there's not the C99-requires-the-feature angle.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Next
From: Tomas Vondra
Date:
Subject: Re: Parallel CREATE INDEX for BRIN indexes