Re: [HACKERS] List of hostaddrs not supported - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [HACKERS] List of hostaddrs not supported
Date
Msg-id bdc54257-7984-9f46-e5de-fff63635e2ce@iki.fi
Whole thread Raw
In response to Re: [HACKERS] List of hostaddrs not supported  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
List pgsql-hackers
On 07/10/2017 01:47 PM, Arthur Zakirov wrote:
> Hello,
>
> 2017-07-10 12:30 GMT+03:00 Heikki Linnakangas <hlinnaka@iki.fi>:
>>
>>
>> I just remembered that this was still pending. I made the documentation
>> changes, and committed this patch now.
>>
>> We're uncomfortably close to wrapping the next beta, later today, but I
>> think it's better to get this into the hands of people testing this, rather
>> than wait for the next beta. I think the risk of breaking something that
>> used to work is small.
>>
> I get this warning during compilation using gcc 7.1.1 20170621:
>
>> fe-connect.c:1100:61: warning: comparison between pointer and zero
> character constant [-Wpointer-compare]
>>     conn->connhost[i].host != NULL && conn->connhost[i].host != '\0')

Thanks, fixed! That check for empty hostname was indeed wrong.

- Heikki




pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: [HACKERS] Double shared memory allocation for SLRU LWLocks
Next
From: Adrien Nayrat
Date:
Subject: Re: [HACKERS] Dumping database creation options and ACLs