Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
Date
Msg-id bcf89ed4-b632-482f-8f1b-0e4f06723ef7@www.fastmail.com
Whole thread Raw
In response to RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
List pgsql-hackers
On Fri, Nov 12, 2021, at 3:10 AM, houzj.fnst@fujitsu.com wrote:
On Fri, Nov 12, 2021 1:33 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Fri, Nov 12, 2021 at 10:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > But won't that generate invalidation for the rel twice in the case
> > (change Replica Identity from Nothing to some index) you mentioned in
> > the previous email?
> >

> Oh, I see the point. I think this is okay because
> AddRelcacheInvalidationMessage doesn't allow to add duplicate rel
> invalidation. If that is the case I wonder why not simply register
> invalidation without any check in the for loop as was the case with
> Tang's original patch?

OK, I also think the code in Tang's original patch is fine.
Attach the patch which register invalidation without any check in the for loop.
WFM.


--
Euler Taveira

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Is heap_page_prune() stats collector accounting wrong?
Next
From: Peter Geoghegan
Date:
Subject: Re: Is heap_page_prune() stats collector accounting wrong?