RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY - Mailing list pgsql-hackers

From houzj.fnst@fujitsu.com
Subject RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY
Date
Msg-id OS0PR01MB571602C82CEFA55470B6BBB794959@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
List pgsql-hackers
On Fri, Nov 12, 2021 1:33 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Fri, Nov 12, 2021 at 10:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > But won't that generate invalidation for the rel twice in the case
> > (change Replica Identity from Nothing to some index) you mentioned in
> > the previous email?
> >
> 
> Oh, I see the point. I think this is okay because
> AddRelcacheInvalidationMessage doesn't allow to add duplicate rel
> invalidation. If that is the case I wonder why not simply register
> invalidation without any check in the for loop as was the case with
> Tang's original patch?

OK, I also think the code in Tang's original patch is fine.
Attach the patch which register invalidation without any check in the for loop.

Best regards,
Hou zj


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
Next
From: Amit Kapila
Date:
Subject: Re: Logical replication timeout problem