Re: handling of heap rewrites in logical decoding - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: handling of heap rewrites in logical decoding
Date
Msg-id bbe2a52b-08ea-c55e-5888-f378618f5e38@2ndquadrant.com
Whole thread Raw
In response to Re: handling of heap rewrites in logical decoding  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: handling of heap rewrites in logical decoding  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On 3/21/18 03:08, Craig Ringer wrote:
> Why was relrewrite / Anum_pg_class_relrewrite inserted at position 28,
> not appended to pg_class?
> 
> I don't see how it'd cause any harm, I'm just curious about the rationale.

Adding it at the end would not be appropriate, since those are
variable-length fields.  So I added it close to other fields of similar
purpose.

> Otherwise, I'm totally happy with what I see here. It's always nice to
> get to the end of a patch and think "wait, that's all?"
> 
> Ready to go.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Jaime Soler
Date:
Subject: Re: Hash join in SELECT target list expression keeps consuming memory
Next
From: Peter Eisentraut
Date:
Subject: Re: PQHost() undefined behavior if connecting string contains bothhost and hostaddr types