Re: New GUC to sample log queries - Mailing list pgsql-hackers

From Adrien Nayrat
Subject Re: New GUC to sample log queries
Date
Msg-id bbb6d622-c48a-125d-a91e-009c519f4992@anayrat.info
Whole thread Raw
In response to Re: New GUC to sample log queries  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: New GUC to sample log queries  (Dmitry Dolgov <9erthalion6@gmail.com>)
Re: New GUC to sample log queries  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
On 11/18/18 12:47 AM, Dmitry Dolgov wrote:
> This patch went through last few commitfests without any activity, but cfbot
> says it still applies and doesn't break any tests. From what I see there was
> some agreement about naming, so the patch is indeed needs more review. Could
> anyone from the reviewers (Vik?) confirm that it's in a good shape?

Thanks Dmitry to bringing this up.

For me, the question is how to name this GUC?
Is "log_sample_rate" is enough? I am not sure because it is only related to
queries logged by log_min_duration_statements.

Alors, I wonder if we should use the same logic for other parameters, such as
log_statement_stats
log_parser_stats
log_planner_stats
log_executor_stats

It was mentioned in this thread
https://www.postgresql.org/message-id/20180710183828.GB3890%40telsasoft.com





pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: make installcheck-world in a clean environment
Next
From: Darafei "Komяpa" Praliaskouski
Date:
Subject: Re: zheap: a new storage format for PostgreSQL