Re: New GUC to sample log queries - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: New GUC to sample log queries
Date
Msg-id CA+q6zcX8k3otLDR13fwm7S16sZdVemQo6Vv9XckJBdp-qw6sQw@mail.gmail.com
Whole thread Raw
In response to Re: New GUC to sample log queries  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: New GUC to sample log queries  (Adrien Nayrat <adrien.nayrat@anayrat.info>)
List pgsql-hackers
> On Mon, 16 Jul 2018 at 23:07, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
>
> On 07/16/2018 05:24 PM, Robert Haas wrote:
> > On Sun, Jul 15, 2018 at 6:53 AM, Vik Fearing
> > <vik.fearing@2ndquadrant.com> wrote:
> >> Hmm.  Not sure if that last word should be _sample, _sampling, _rate, or
> >> a combination of those.
> >
> > +1 for rate or sample_rate.  I think "sample" or "sampling" without
> > "rate" will not be very clear.
> >
>
> 1+ to sample_rate
>
> It's what auto_explain and pgbench uses, so let's keep the naming
> consistent.

This patch went through last few commitfests without any activity, but cfbot
says it still applies and doesn't break any tests. From what I see there was
some agreement about naming, so the patch is indeed needs more review. Could
anyone from the reviewers (Vik?) confirm that it's in a good shape?


pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: pg11.1 jit segv
Next
From: Thomas Munro
Date:
Subject: Re: Postgres, fsync, and OSs (specifically linux)