Re: Improve error message for ICU libraries if pkg-config is absent - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Improve error message for ICU libraries if pkg-config is absent
Date
Msg-id b903792ab7ca37af4be6d959ce1ea5b548f19391.camel@j-davis.com
Whole thread Raw
In response to Re: Improve error message for ICU libraries if pkg-config is absent  (Michael Banck <mbanck@gmx.net>)
Responses Re: Improve error message for ICU libraries if pkg-config is absent
List pgsql-hackers
On Fri, 2024-08-09 at 11:44 +0200, Michael Banck wrote:
> So maybe the better change is to just remove the explicit error
> message
> again and depend on PKG_CHECK_MODULES erroring out helpfully?  The
> downside would be that the hint about specifying --without-icu to get
> around this would disappear, but I think somebody building from
> source
> can figure that out more easily than the subtle issue that pkg-config
> is
> not installed.

That looks good to me. Does anyone have a different opinion? If not,
I'll go ahead and commit (but not backport) this change.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Skip adding row-marks for non target tables when result relation is foreign table.
Next
From: Jeff Davis
Date:
Subject: Re: Typo in unicode_assigned() document PG17